search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 58 forks source link

Adding base64 encoding from web-editor and removed old encoding #339

Closed rorticus closed 7 years ago

rorticus commented 7 years ago

Type: bug / feature

The following has been addressed in the PR:

Description:

Removing old encoding.ts and replaced it with the base64 methods from web-editor. It doesn't look like the code from encoding.ts was being used, so I think we can just ditch it.

Resolves #299

codecov[bot] commented 7 years ago

Codecov Report

Merging #339 into master will decrease coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   94.14%   93.98%   -0.16%     
==========================================
  Files          40       40              
  Lines        2202     2063     -139     
  Branches      408      380      -28     
==========================================
- Hits         2073     1939     -134     
+ Misses         51       50       -1     
+ Partials       78       74       -4
Impacted Files Coverage Δ
src/base64.ts 100% <100%> (ø)
src/main.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f777ae6...07f7cc4. Read the comment docs.