search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 62 forks source link

Remove destructuring from generateRequestUrl signature #363

Closed nicknisi closed 6 years ago

nicknisi commented 6 years ago

Description:

The generateRequestUrl function is correct, but its usage of destructuring with a default argument is throwing an error in the way that ts-loader reads the code. Issue TypeStrong/ts-loader#442 describes the issue, but it hasn't really had much progress, and it's easier to just change this.

nicknisi commented 6 years ago

It looks like the errors are related to errors in functional tests, and not to changes in this PR.

Running "ts:dev" (ts) task
Compiling...
Using tsc v2.4.2
tests/functional/text/textPlugin.ts(25,30): error TS2339: Property 'text' does not exist on type '{}'.
tests/functional/text/textPlugin.ts(30,30): error TS2339: Property 'text' does not exist on type '{}'.
tests/functional/text/textPlugin.ts(35,30): error TS2339: Property 'text' does not exist on type '{}'.
tests/functional/text/textPlugin.ts(40,30): error TS2339: Property 'text' does not exist on type '{}'.

I'm happy to address, but I can't reproduce locally.

kitsonk commented 6 years ago

Found the issue and fixed it in #364. I am not sure why it wasn't reproducible on your machine though.