Make tslib a dependency instead of a dev-dependency

dojo / core

:rocket: Dojo 2 - language helpers and utilities.

http://dojo.io

Other

213 stars 58 forks source link

Make tslib a dependency instead of a dev-dependency #377

Closed mgroenhoff closed 6 years ago

mgroenhoff commented 6 years ago

Type: bug

The following has been addressed in the PR:

[X] There is a related issue
[ ] All code has been formatted with prettier as per the readme code style guidelines
[ ] Unit or Functional tests are included in the PR

Description:

Resolves #372

jsf-clabot commented 6 years ago

All committers have signed the CLA.

matt-gadd commented 6 years ago

should we raise a @dojo/meta issue for this? it should be a dependency across all of the @dojo packages.

mgroenhoff commented 6 years ago

Good point. I did not look beyond @dojo/core and its dependencies but a quick look at other packages shows that at least also @dojo/widgets does have "importHelpers": true while not having any dependency on tslib. Maybe there are more!

Edit: I found some more and went ahead and created the issue https://github.com/dojo/meta/issues/226