dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 58 forks source link

has.ts causes loading the main bundle to crash in Internet Explorer 11 in https #387

Closed szwoelf closed 6 years ago

szwoelf commented 6 years ago

Bug

When using a bundled application with Internet Explorer 11 together with https the bundle is not loaded. IE raises an "access denied" error in the main bundle.

Package Version: dojo RC1 (and RC2)

Code

can be tested with:

import request from '@dojo/core/request'; console.log(request);

Actual behavior:

IE 11 will not show the rotating elements - it will show an error in the console (no SVG, ... )

szwoelf commented 6 years ago

Internet Explorer seems to have a problem with the request to http://www.google.com .... (see line 22 in has.ts) ....

dasa commented 6 years ago

Maybe it should be using https, like it does here in Dojo 1: https://github.com/dojo/dojo/blob/master/request/xhr.js#L40

szwoelf commented 6 years ago

Hi ... yes. I patched this in the has.js in the node_modules, performed a build and re-tested this in IE. Using the URL https://www.google.com works. Possibly the comment of the code mentioned by @dasa should also be added ...

agubler commented 6 years ago

@szwoelf do you fancy raising a pull request to fix this?