search

dojo / dijit-themes

Dojo 1 - modern themes
Other
29 stars 21 forks source link

ColorPalette white tile is indistinguishable from background #11

Open btfou opened 9 years ago

btfou commented 9 years ago

As per discussion in https://github.com/dojo/themes/pull/9, ColorPalette white tile is indistinguishable from background.

Claro: claro

Flat: flat

@wkeese I too noticed this. The hover effect on the tiles is nice and I'd prefer not to put borders on all the tiles. Haven't had a chance to dig into ColorPalette's CSS and classes. Perhaps a light border on the white tile, as long as it's not too hacky. I'm open to suggestions as well.

wkeese commented 9 years ago

Sounds good to me.

I guess you mentioned the hover effect because we are talking about borders, and the hover effect also displays a border. I think it's possible to get both a tight border around the white tile, and keep the large hover border. For example, you could put the white tile's border on the <img class=dijitColorPaletteSwatch>, and that wouldn't interfere with your hover border on the <span class=dijitPaletteCell>.

Alternately/additionally you could do the hover effect using outline rather than border. That might be a marginal improvement since you don't need the border:transparent setting for the non-hover case.

wkeese commented 8 years ago

That change has nothing to do with this ticket.