search

dojo / dijit-themes

Dojo 1 - modern themes
Other
29 stars 21 forks source link

Add Gruntfile.js to the list of copyOnly files #13

Closed feibeck closed 8 years ago

feibeck commented 8 years ago

Using the themes in a Dojo build results in an error:

error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: themes/Gruntfile; error: ReferenceError: module is not defined

Adding Gruntfile.js to the list of copyOnly removes it from the files marked as AMD. This fixes the issue and a Dojo build can be made with the flat theme.

dylans commented 8 years ago

Thanks @feibeck , I'll land this asap.

dylans commented 8 years ago

Thanks @feibeck , closed via b812a1bf.

feibeck commented 8 years ago

:+1: :smile:

gibbok commented 8 years ago

Problem persist when building using 'Rhino' instead of 'Node'. More details on this ticket: https://github.com/dojo/themes/issues/30