search

dojo / dojo.io

Dojo - source for the dojo.io website
Other
17 stars 43 forks source link

Add a tutorial for generating custom elements with Dojo #479

Closed JamesLMilner closed 5 years ago

JamesLMilner commented 5 years ago

This provides a tutorial to our users explaining how to convert their Dojo widgets to CustomElements and using them in another page.

KaneFreeman commented 5 years ago
  1. There are other properties the decorator can take, what are they and what do they do? This an advanced tutorial so explaining those even in an aside would be nice.
  2. "This file will be outputted to the a path of output/dist/ in it's own folder called workerprofile." The wording seems odd here. The command can (and will) output more than one file. A .map file and if there is CSS, a .css file. Something like "The output of this command can be found in it's own folder called workprofile under the output/dist folder". Then maybe explain the files that it will output in an aside or something. You do mention the css file in the next section.
  3. Personal preference: The rest of the tutorials start their summary with "In this tutorial, ...".
  4. "Hopefully you can see how this might beneficial with regards to sharing your Dojo Widgets around your projects". If you are a new user to the concept of custom elements, it might be better to spell this out instead of asking them to basically come up with their own reasons.
  5. "for example between applications are or teams that are using different approaches to writing applications." The wording here seems off. I get the gist, but had to read it a couple times.
  6. Finished demo does not have the "blank web page" you made at the end of the tutorial
KaneFreeman commented 5 years ago

The changes look good.