dojo / dojox

Dojo 1 - extras library. Please submit bugs to https://bugs.dojotoolkit.org/
https://dojotoolkit.org/
Other
151 stars 229 forks source link

dojox/dtl/_Templated does not work any more with widgets in template #327

Open edurocher opened 3 years ago

edurocher commented 3 years ago

We have upgraded from 1.10 to 1.16 and noticed that some of our widgets using dojox/dtl/_Templated did not work any more because the sub-widgets contained in the template were not created.

Investigating a little more, it appears to be caused by this commit in dijit that removes the widgetsInTemplate flag. This flag is still expected by dojox/dtl/_Templated to decide to parse sub-widgets, though.

Our workaround is to add the flag explicitly in our widgets. Everything seems to work fine then.

I don't know if there is enough interest to fix this in dtl, but a cleaner solution would be to do the same detection in dtl as in dijit to know if there are any widgets in the template.