dojo / framework

Dojo Framework. A Progressive Framework for Modern Web Apps
https://dojo.io/
Other
580 stars 79 forks source link

Update shim/global.ts to use `globalThis` #222

Closed dasa closed 5 years ago

dasa commented 5 years ago

Bug

Package Version: 5

Code

Chrome, Safari TP and TS are using globalThis rather than global. See: https://github.com/Microsoft/TypeScript/pull/29332 (This PR makes it sound like TS will handle this in the future such that the shim would no longer be needed.)

Expected behavior:

Actual behavior:

dasa commented 5 years ago

See: https://mathiasbynens.be/notes/globalthis

maier49 commented 5 years ago

Resolved by #437