dojo / framework

Dojo Framework. A Progressive Framework for Modern Web Apps
https://dojo.io/
Other
580 stars 79 forks source link

Test harness should throw on missing selectors #318

Closed aciccarello closed 5 years ago

aciccarello commented 5 years ago

Enhancement The testing harness should throw when the selector isn't found. Th.is would help debug failing tests

Package Version:

Code

h.trigger('@nonExistantSelector', 'whatToTrigger');

Expected behavior: The trigger call will throw an error indicating the selector could not be found.

Actual behavior: The trigger passes silently.

ferni1988 commented 5 years ago

Stop

Sent from my iPhone

On Apr 15, 2019, at 11:20 AM, Anthony Ciccarello notifications@github.com wrote:

Enhancement The testing harness should throw when the selector isn't found. Th.is would help debug failing tests

Package Version:

Code

h.trigger('@nonExistantSelector', 'whatToTrigger'); Expected behavior: The trigger call will throw an error indicating the selector could not be found.

Actual behavior: The trigger passes silently.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

aciccarello commented 5 years ago

@ferni1988 GitHub doesn't support unsubscribing that way (it replies to the issue). You will have to login to GitHub to manage your email preferences or un-watch a repository.