Render `key` as dom property in `debug` mode

dojo / framework

Dojo Framework. A Progressive Framework for Modern Web Apps

https://dojo.io/

Other

585 stars 78 forks source link

Render `key` as dom property in `debug` mode #49

Closed agubler closed 4 years ago

agubler commented 6 years ago

@tomdye commented on Mon Jun 11 2018

Enhancement

It would be advantageous to render a widget / DNode key onto the corresponding dom node when building for debug. This would be especially helpful when writing integration / BDD tests as the selectors can then target the key as we do in our unit tests.

tomdye commented 4 years ago

Since raising this issue via Ant we have looked into this more and settled on the approach of using data-test attributes where we need to target a specific node within functional tests. This solution works well and is recommended in the cypress documentation. The initial suggestion of keeping key for a debug mode build would not have allowed us to run functionals against production built code so I believe we can now close this issue.