agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

[ ] There is a related issue
[ ] All code has been formatted with prettier as per the readme code style guidelines
[ ] Unit or Functional tests are included in the PR

Description:

For deferred properties the renderers resolve to the "final", i.e. run the deferred properties twice but it doesn't pass the inserted flag correctly.

This passes the inserted flag as true for the second process.

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1759cedffc512c70ad8260010655d4bb0357a041:

Sandbox	Source
dojo/dojo-codesandbox-template	Configuration

codecov[bot] commented 3 years ago

Codecov Report

Merging #881 (3571dcd) into master (69a6a61) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         127      127           
  Lines        8010     8010           
  Branches     1872     1874    +2     
=======================================
  Hits         7566     7566           
  Misses        444      444

Impacted Files	Coverage Δ
src/testing/decorate.ts	`98.01% <100.00%> (ø)`
src/testing/harness/harness.ts	`93.87% <100.00%> (ø)`
src/testing/harness/support/selector.ts	`100.00% <100.00%> (ø)`
src/testing/renderer.ts	`97.32% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69a6a61...1759ced. Read the comment docs.

dojo / framework

Pass inserted flag correctly to deferred props in test renderers #881

Codecov Report