dojo / framework

Dojo Framework. A Progressive Framework for Modern Web Apps
https://dojo.io/
Other
586 stars 79 forks source link

Fix Resources Invalidation Strategy #882

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

These changes address a few small bugs in the invalidation and caching logic used by resource:

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a79bb3838fd75074f62987053c33f4457afba921:

Sandbox Source
dojo/dojo-codesandbox-template Configuration
codecov[bot] commented 3 years ago

Codecov Report

Merging #882 (a79bb38) into master (69a6a61) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   94.45%   94.52%   +0.06%     
==========================================
  Files         127      127              
  Lines        8010     8020      +10     
  Branches     1872     1874       +2     
==========================================
+ Hits         7566     7581      +15     
+ Misses        444      439       -5     
Impacted Files Coverage Δ
src/core/middleware/resources.ts 95.68% <100.00%> (+1.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69a6a61...a79bb38. Read the comment docs.