dojo / framework

Dojo Framework. A Progressive Framework for Modern Web Apps
https://dojo.io/
Other
586 stars 79 forks source link

Make inputs partially only controlled #887

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

Changing how vdom work when setting values on an input element. This is to resolve an issue with Safari that jumps the caret to the end of the input when updating the value.

Resolves #886

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c65779e2d6722d73fe0c1af20de3901284547ad:

Sandbox Source
dojo/dojo-codesandbox-template Configuration
codecov[bot] commented 3 years ago

Codecov Report

Merging #887 (5c65779) into master (ad9f5e4) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #887   +/-   ##
=======================================
  Coverage   94.53%   94.54%           
=======================================
  Files         127      127           
  Lines        8113     8114    +1     
  Branches     1894     1894           
=======================================
+ Hits         7670     7671    +1     
  Misses        443      443           
Impacted Files Coverage Δ
src/core/vdom.ts 97.78% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad9f5e4...5c65779. Read the comment docs.