dojo / framework

Dojo Framework. A Progressive Framework for Modern Web Apps
https://dojo.io/
Other
586 stars 79 forks source link

Cache the function wrapper, no need to recreate each render. #903

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug/feature

The following has been addressed in the PR:

Description:

There is no need to recreate the property function wrapper each render, in addition this is causing issues with the custom element wrapper because the functions will always be referentially different.

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51aa1c22a1970c05c85cd9ebd4bb3d09274e3cba:

Sandbox Source
dojo/dojo-codesandbox-template Configuration
codecov[bot] commented 3 years ago

Codecov Report

Merging #903 (51aa1c2) into master (29854e3) will increase coverage by 0.00%. The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   94.60%   94.61%           
=======================================
  Files         127      127           
  Lines        8141     8145    +4     
  Branches     1900     1901    +1     
=======================================
+ Hits         7702     7706    +4     
  Misses        439      439           
Impacted Files Coverage Δ
src/core/vdom.ts 97.79% <88.88%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29854e3...51aa1c2. Read the comment docs.