dojo / framework

Dojo Framework. A Progressive Framework for Modern Web Apps
https://dojo.io/
Other
586 stars 79 forks source link

Link: Always pass the target attribute regardless of whether the event is intercepted #907

Closed matt-gadd closed 3 years ago

matt-gadd commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description: We should always forward the target property to the anchor tag for Link.

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df2604a26677f9bd2b7661268e08846701141480:

Sandbox Source
dojo/dojo-codesandbox-template Configuration
codecov[bot] commented 3 years ago

Codecov Report

Merging #907 (df2604a) into master (a7481f7) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #907   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files         127      127           
  Lines        8145     8150    +5     
  Branches     1901     1906    +5     
=======================================
+ Hits         7706     7711    +5     
  Misses        439      439           
Impacted Files Coverage Δ
src/routing/Link.ts 96.15% <100.00%> (+0.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7481f7...df2604a. Read the comment docs.