dojo / grunt-dojo2-extras

Grunt tasks and code supporting continuous delivery across projects. Deploys to gh-pages and latest branch.
https://dojo.github.io/grunt-dojo2-extras/
Other
0 stars 6 forks source link

Current version of typedoc not compatible with TypeScript 2.4.X #51

Closed maier49 closed 7 years ago

maier49 commented 7 years ago

Typedoc was recenty upgraded to support TypeScript 2.4.1, but we're relying on a fork that hasn't been updated. The dojo.io build currently fails on what appears to be an issue compiling:

Using TypeScript 2.2.2 from /home/travis/build/dojo/dojo.io/node_modules/grunt-dojo2-extras/node_modules/typescript/lib
Error: /home/travis/build/dojo/dojo.io/node_modules/@types/handlebars/index.d.ts(21)
 ',' expected.
Error: /home/travis/build/dojo/dojo.io/node_modules/@types/handlebars/index.d.ts(23)
 ',' expected.
Error: /home/travis/build/dojo/dojo.io/node_modules/@types/handlebars/index.d.ts(98)
 ',' expected.

I haven't verified whether we need to upgrade all the way to TypeScript 2.4 to fix that issue or whether moving to 2.3.2, is sufficient.

maier49 commented 7 years ago

This has been resolved by #55