search

dojo / grunt-dojo2

Dojo 2 - Grunt tasks and configuration (internal use)
Other
4 stars 16 forks source link

Add css nano to post css processors #168

Closed maier49 closed 7 years ago

maier49 commented 7 years ago

Type: feature

The following has been addressed in the PR:

Description: This adds cssnano to the post-css processors used for the dev and dist builds, per #96. That ticket seems to indicate that postcss-import should be removed from the dev build. Doing so breaks the build because the variables used in many files that are imported from other files can no longer be resolved. I'm not sure if there was some more context behind the original issue on why we wanted to remove postcss-import or what the alternative would be for a dev build.

Resolves #96

codecov[bot] commented 7 years ago

Codecov Report

Merging #168 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   69.62%   69.67%   +0.04%     
==========================================
  Files          27       27              
  Lines         642      643       +1     
  Branches      102      102              
==========================================
+ Hits          447      448       +1     
  Misses        186      186              
  Partials        9        9
Impacted Files Coverage Δ
tasks/util/postcss.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c50e6fd...71f7546. Read the comment docs.