rorticus commented 7 years ago

Updating the intern helper to accept options. Packages can then specify their own config with,

{
    "browser": {
        "loader": {
            "script": "./node_modules/grunt-dojo2/lib/intern/internLoader.js",
            "options": {
                "packages": [
                    { "name": "my-package", "location": "my-location" }
                ]
            }
        }
    }
}

Note that we need to specify the browser.loader.script manually as intern does not allow us to specify the loader options without the loader.

kitsonk commented 7 years ago

Is there a related issue for this?

codecov[bot] commented 7 years ago

Codecov Report

Merging #171 into master will decrease coverage by 0.39%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #171     +/-   ##
=========================================
- Coverage   70.57%   70.18%   -0.4%     
=========================================
  Files          28       28             
  Lines         656      664      +8     
  Branches      104      104             
=========================================
+ Hits          463      466      +3     
- Misses        184      189      +5     
  Partials        9        9

Impacted Files	Coverage Δ
lib/intern/internLoader.js	`61.11% <0%> (-18.89%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82dc05f...260554a. Read the comment docs.

rorticus commented 7 years ago

Well. it's VAGUELY related to the shim updates. We merged the changes for grunt-dojo2 to contain the intern loader for the rest of the packages to use. This is an update to allow further customization by the packages.

dojo / grunt-dojo2

Updating intern loader to accept options #171

Codecov Report