dojo / has

:rocket: Dojo 2 - feature detection library.
http://dojo.io
Other
3 stars 18 forks source link

What happened to "host-rhino" ? #24

Open sebilasse opened 7 years ago

sebilasse commented 7 years ago

Version and Environment:

Dojo2 version: recent

Environment(s): all (detection)

Code

if (has('host-node') || has('host-rhino')) {}

Expected behavior:

In dojo1 'host-rhino' was defined in has

Actual behavior:

TypeError: Attempt to detect unregistered has feature "host-rhino"
kitsonk commented 7 years ago

As with a lot of things Dojo 2, like support for IE6 - 9, the planned support matrix for Dojo 2 is different than that of Dojo 1. Right now the support matrix is planned as:

I assume you have a need/desire to support Rhino? We would consider this a request for a feature enhancement, as we haven't assessed what it would take to support Rhino at this point in time. Anyone downstream of course can define a feature test and branch their code appropriately. Also, host-browser and host-node are really feature detection "hammers" that are usually not the right way to branch code and we have been trying to make sure granular feature detection tests that really express the feature we are trying to detect/determine. This significantly improves the future proofing of the code.

What specific branch were you trying/wanting to create that required host-rhino?

dylans commented 7 years ago

@sebilasse could you add a bit more detail about what you're looking for with Rhino support? Also see the note that we're hoping to use more granular feature detection rather than the hammer of something being node or rhino or a browser whenever possible.

dylans commented 7 years ago

Marking this as "long-grass" which means leave it open for future consideration, but there's no current plan at the moment for this. More specific requests for supporting features needed for rhino would be considered as well.