search

dojo / has

:rocket: Dojo 2 - feature detection library.
http://dojo.io
Other
3 stars 18 forks source link

Migration to TS2.0 #6

Closed agubler closed 8 years ago

agubler commented 8 years ago

Fixes #5

codecov-io commented 8 years ago

Current coverage is 97.77% (diff: 83.33%)

Merging #6 into master will decrease coverage by 2.22%

@@           master         #6   diff @@
========================================
  Files           2          2          
  Lines          43         45     +2   
  Methods         1          1          
  Messages        0          0          
  Branches       12         13     +1   
========================================
+ Hits           43         44     +1   
- Misses          0          1     +1   
  Partials        0          0

Powered by Codecov. Last update 8ba42d1...9248dba

kitsonk commented 8 years ago

👍 for this, but I realised that we should have a "task" for readonly usage and add it where applicable. I don't know if there are any legitimate uses in has off hand. If we don't do this analysis for this PR, we should have an issue to track we make sure we do it in the future.

agubler commented 8 years ago

I was thinking about readonly only this morning, we should certainly add issues across the repos to analyse and fix post TS2.0 pull requests. I'll add them today.

kitsonk commented 8 years ago

Ok, created the issues so this is now firmly 👍