search

dojo / i18n

:rocket: Dojo 2 - internationalization library.
http://dojo.io
Other
6 stars 19 forks source link

Wrong path for "globalize" dependency #39

Closed sebilasse closed 7 years ago

sebilasse commented 7 years ago

npm: alpha3

When installing it says Cannot find module 'globalize/globalize/message'

It is imported as "globalize/globalize/message" but the path is "globalize/dist/globalize/message"

also there is no module 'cldr/unresolved'; Cannot find module 'cldr/unresolved' /dojo-i18n/cldr/load.js:11

mwistrand commented 7 years ago

This is fixed as part of #33 but I may separate this out as a separate hot fix if that PR doesn't land in the next few days.

sebilasse commented 7 years ago

@mwistrand No worries. Already hotfixed anything myself in the "old year" ... Also node.js complained about global_1.default.require being undefined (in i18n.js / getJson and in cldr/load.js / getJson)

var arr = (!!global_1.default.require) ? [global_1.default.require] : [];
paths = paths.map(function (path) { return path + '.json'; });
return load_1.default.apply(void 0, arr.concat(paths));

works. However, dojo community : Have a Happy New Year !

mwistrand commented 7 years ago

This is fixed in #41, but we are running into CI issues at the moment, so I'm hesitant to merge/release just yet. I apologize for the delay.

mwistrand commented 7 years ago

This is resolved in #41, and will be included in the alpha.4 release.