Closed lzhoucs closed 7 years ago
Now that dojo/core#270 has landed, this PR can be updated to use the useDefault
mapper, correct?
I think so too, Matt! Will do it shortly!
@mwistrand @lzhoucs I didn't realize this PR existed... 😄 I have https://github.com/dojo/i18n/pull/56 to update load
to use the new request API from dojo/core. If you can use anything from there, great, otherwise just toss it.
@rorticus thanks! This one is simply updating the load
usage. It is not touching request
.
Merging #45 into master will decrease coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
- Coverage 98.81% 98.8% -0.02%
=========================================
Files 10 10
Lines 338 334 -4
Branches 41 41
=========================================
- Hits 334 330 -4
Partials 4 4
Impacted Files | Coverage Δ | |
---|---|---|
src/i18n.ts | 97.45% <100%> (-0.09%) |
:x: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f370826...00f4edb. Read the comment docs.
This one is very minor anyways. Maybe we can just close it and add those lines whenever we clean up the code in the future.
Type: cleanup
Description:
This cleans up boilerplate code that has been baked into
dojo-core/load
.Note, The build/unit tests should fail until https://github.com/dojo/core/pull/262 is released.
Depends on: https://github.com/dojo/core/pull/262
Related Issue: N/A