dojo / i18n

:rocket: Dojo 2 - internationalization library.
http://dojo.io
Other
6 stars 19 forks source link

cldrjs missing in package.json #49

Closed sebilasse closed 7 years ago

sebilasse commented 7 years ago

The code says

// required for Globalize/Cldr to properly resolve locales in the browser. require("cldrjs/dist/cldr/unresolved");

But cldrjs is missing in package.json

dylans commented 7 years ago

@sebilasse

See https://github.com/dojo/i18n/blob/master/package.json#L44-L45

which points to Globalize as a dependency, which then has:

https://github.com/globalizejs/globalize/blob/master/package.json#L73

So it's pulling in cldrjs as a result of pulling in globalize...

How are you using dojo/i18n (via widget-core, or directly)? Are you installing it via npm, e.g. npm install @dojo/i18n?

sebilasse commented 7 years ago

@dylans Just installed alpha.4 via npm - using it directly for now

agubler commented 7 years ago

@sebilasse which version of npm are you using?

sebilasse commented 7 years ago

@agubler 2.14.7

agubler commented 7 years ago

@sebilasse we only support npm 3+, we need to add that to the engines in the package.json.

sebilasse commented 7 years ago

@agubler @dylans : I see. Updating npm and putting the changelog to my endless reading list ;) ... Feel free to close it. Thanks for realtime replies.

agubler commented 7 years ago

You're very welcome, the reason we need npm 3+ is that we need all of the dependencies to be pulled to the top level (flatten) node_modules which is not supported by npm < 3

agubler commented 7 years ago

Closing as per @sebilasse