dojo / i18n

:rocket: Dojo 2 - internationalization library.
http://dojo.io
Other
6 stars 19 forks source link

Move common load methods into cldr/load/default #69

Closed mwistrand closed 7 years ago

mwistrand commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

Blocked by #67 (failing tests). cldr/load/webpack no longer includes the values imported from cldr/load in webpack builds. Separating the common methods between the two into a shared module circumvents this issue. To preserve the existing API, exports from cldr/load/default are re-exported by both cldr/load and cldr/load/webpack.

Resolves #65

codecov[bot] commented 7 years ago

Codecov Report

Merging #69 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   98.88%   98.91%   +0.02%     
==========================================
  Files          10       11       +1     
  Lines         360      367       +7     
  Branches       48       48              
==========================================
+ Hits          356      363       +7     
  Partials        4        4
Impacted Files Coverage Δ
src/cldr/load.ts 96.15% <100%> (-2.74%) :x:
src/cldr/load/default.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42370c5...8311f92. Read the comment docs.