search

dojo / interop

Provides bindings and interoperability between Dojo packages and other libraries
Other
1 stars 14 forks source link

Add static references for Dijit constructor #11

Closed kitsonk closed 6 years ago

kitsonk commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

By holding static references on the class object, it appears to stop IE11 from doing mis-appropriate GC on arguments passed the mixin function. Gotta love browser inconsistency.

Resolves #10

codecov[bot] commented 7 years ago

Codecov Report

Merging #11 into master will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   94.64%   94.82%   +0.18%     
==========================================
  Files           2        2              
  Lines          56       58       +2     
  Branches       12       12              
==========================================
+ Hits           53       55       +2     
  Partials        3        3
Impacted Files Coverage Δ
src/dijit/DijitWrapper.ts 95.83% <100%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 765dc2c...789c80b. Read the comment docs.