dojo / interop

Provides bindings and interoperability between Dojo packages and other libraries
Other
1 stars 14 forks source link

interop does not work as described, resulting in compile errors #36

Closed ziegi closed 4 years ago

ziegi commented 6 years ago

Bug

Testing with the Code provided in the Interop Readme, as well as with the Tutorial Code: https://dojo.io/tutorials/assets/1040_dojo1_dijits-finished.zip results in Errors, the first ones are: ./node_modules/dojo/i18n.js!./node_modules/dijit/nls/loading.js Module build failed: ReferenceError: define is not defined

in a working dojo2 App add the three lines: import * as CalendarDijit from 'dijit/Calendar'; import DijitWrapper from '@dojo/interop/dijit/DijitWrapper'; const Calendar = DijitWrapper(CalendarDijit); and the compile Errors get thrown

same with the tutorial code https://dojo.io/tutorials/assets/1040_dojo1_dijits-finished.zip

expected to compile with the sample code and the setup from the turorial: https://dojo.io/tutorials/1040_dojo1_dijits/ or docs: https://dojo.io/docs/index.html#doc--dojo__interop__v2_0_0

dojo build app --mode dev --watch ℹ cli-build-app: 1.0.0 ℹ typescript: 2.6.2 ✔ hash: e3924cd9824ecaa19e7d ✖ errors: 16 ⚠ warnings: 41 errors: ./node_modules/dojo/i18n.js!./node_modules/dijit/nls/loading.js Module build failed: ReferenceError: define is not defined at Object. (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dojo/ i18n.js:1:63) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at loadLoader (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/loadLoader.js :13:17) at iteratePitchingLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:169:2) at runLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:362:2) at NormalModule.doBuild (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:182 :3) at NormalModule.build (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:275 :15) at Compilation.buildModule (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:151: 10) at factoryCallback (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:344: 12) at factory (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:241:5) at applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:94:13) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:26 8:11 at NormalModuleFactory.params.normalModuleFactory.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/CompatibilityPlugin .js:52:5) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:27 0:14 at NormalModuleFactory.nmf.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleReplace mentPlugin.js:39:12) at NormalModuleFactory.applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/b iz-e-corp/node_modules/tapable/lib/Tapable.js:272:13) at resolver (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:69:10) at process.nextTick (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:194:7) at _combinedTickCallback (internal/process/next_tick.js:131:7) at process._tickDomainCallback (internal/process/next_tick.js:218:9) @ ./node_modules/dijit/layout/ContentPane.js 1:0-665:2 @ ./node_modules/dijit/TitlePane.js @ ./node_modules/dijit/Fieldset.js @ ./src/dijit/Fieldset.ts @ ./src/widgets/WorkerForm.ts @ ./src/widgets/App.ts @ ./src/main.ts @ multi ./src/main.css ./src/main.ts,./node_modules/dojo/text.js!./node_modules/dijit/templates/Fieldset.html Module build failed: ReferenceError: define is not defined at Object. (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dojo/ text.js:1:63) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at loadLoader (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/loadLoader.js :13:17) at iteratePitchingLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:169:2) at runLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:362:2) at NormalModule.doBuild (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:182 :3) at NormalModule.build (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:275 :15) at Compilation.buildModule (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:151: 10) at factoryCallback (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:344: 12) at factory (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:241:5) at applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:94:13) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:26 8:11 at NormalModuleFactory.params.normalModuleFactory.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/CompatibilityPlugin .js:52:5) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:27 0:14 at NormalModuleFactory.nmf.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleReplace mentPlugin.js:39:12) at NormalModuleFactory.applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/b iz-e-corp/node_modules/tapable/lib/Tapable.js:272:13) at resolver (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:69:10) at process.nextTick (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:194:7) at _combinedTickCallback (internal/process/next_tick.js:131:7) at process._tickDomainCallback (internal/process/next_tick.js:218:9) @ ./node_modules/dijit/Fieldset.js 1:0-41:2 @ ./src/dijit/Fieldset.ts @ ./src/widgets/WorkerForm.ts @ ./src/widgets/App.ts @ ./src/main.ts @ multi ./src/main.css ./src/main.ts,./node_modules/dojo/text.js!./node_modules/dijit/form/templates/Button.html Module build failed: ReferenceError: define is not defined at Object. (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dojo/ text.js:1:63) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at loadLoader (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/loadLoader.js :13:17) at iteratePitchingLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:169:2) at runLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:362:2) at NormalModule.doBuild (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:182 :3) at NormalModule.build (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:275 :15) at Compilation.buildModule (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:151: 10) at factoryCallback (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:344: 12) at factory (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:241:5) at applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:94:13) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:26 8:11 at NormalModuleFactory.params.normalModuleFactory.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/CompatibilityPlugin .js:52:5) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:27 0:14 at NormalModuleFactory.nmf.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleReplace mentPlugin.js:39:12) at NormalModuleFactory.applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/b iz-e-corp/node_modules/tapable/lib/Tapable.js:272:13) at resolver (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:69:10) at process.nextTick (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:194:7) at _combinedTickCallback (internal/process/next_tick.js:131:7) at process._tickDomainCallback (internal/process/next_tick.js:218:9) @ ./node_modules/dijit/form/Button.js 1:0-124:2 @ ./src/dijit/form/Button.ts @ ./src/widgets/WorkerForm.ts @ ./src/widgets/App.ts @ ./src/main.ts @ multi ./src/main.css ./src/main.ts,./node_modules/dojo/text.js!./node_modules/dijit/templates/TitlePane.html Module build failed: ReferenceError: define is not defined at Object. (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dojo/ text.js:1:63) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at loadLoader (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/loadLoader.js :13:17) at iteratePitchingLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:169:2) at runLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:362:2) at NormalModule.doBuild (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:182 :3) at NormalModule.build (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModule.js:275 :15) at Compilation.buildModule (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:151: 10) at factoryCallback (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/Compilation.js:344: 12) at factory (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:241:5) at applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:94:13) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:26 8:11 at NormalModuleFactory.params.normalModuleFactory.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/CompatibilityPlugin .js:52:5) at /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/tapable/lib/Tapable.js:27 0:14 at NormalModuleFactory.nmf.plugin (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleReplace mentPlugin.js:39:12) at NormalModuleFactory.applyPluginsAsyncWaterfall (/dojo2/1040_dojo1_dijits/finished/b iz-e-corp/node_modules/tapable/lib/Tapable.js:272:13) at resolver (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:69:10) at process.nextTick (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/webpack/lib/NormalModuleFactory .js:194:7) at _combinedTickCallback (internal/process/next_tick.js:131:7) at process._tickDomainCallback (internal/process/next_tick.js:218:9) @ ./node_modules/dijit/TitlePane.js 1:0-292:2 @ ./node_modules/dijit/Fieldset.js @ ./src/dijit/Fieldset.ts @ ./src/widgets/WorkerForm.ts @ ./src/widgets/App.ts @ ./src/main.ts @ multi ./src/main.css ./src/main.ts,./node_modules/dojo/text.js!./node_modules/dijit/form/templates/TextBox.html Module build failed: ReferenceError: define is not defined at Object. (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dojo/ text.js:1:63) at Module._compile (module.js:652:30) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at loadLoader (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/loadLoader.js :13:17) at iteratePitchingLoaders (/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/loader-runner/lib/LoaderRunner. js:169:2) ..... @ multi ./src/main.css ./src/main.ts,./node_modules/dojo/Deferred.js Module not found: Error: Can't resolve 'config-deferredInstrumentation?./promise/instrumentation' in '/data/dokumente/zkm/inve ntur/rewrite/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dojo' resolve 'config-deferredInstrumentation?./promise/instrumentation' in '/dojo2/1040_dojo1_d ijits/finished/biz-e-corp/node_modules/dojo' Parsed request is a module using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dojo/p ackage.json (relative path: .) Field 'browser' doesn't contain a valid alias configuration after using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/ dojo/package.json (relative path: .) resolve as module looking for modules in /dojo2/1040_dojo1_dijits/finished/biz-e-corp using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/package.json (relative path: .) Field 'browser' doesn't contain a valid alias configuration after using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/package .json (relative path: .) using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/package.jso n (relative path: ./config-deferredInstrumentation) no extension Field 'browser' doesn't contain a valid alias configuration /dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation doesn't exist .ts Field 'browser' doesn't contain a valid alias configuration /dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation. ts doesn't exist .tsx Field 'browser' doesn't contain a valid alias configuration /dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation. tsx doesn't exist .js Field 'browser' doesn't contain a valid alias configuration /dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation. js doesn't exist as directory /dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation doesn't exist looking for modules in /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/package.json (relative path: ./node_modules) Field 'browser' doesn't contain a valid alias configuration after using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/package .json (relative path: ./node_modules) using description file: /dojo2/1040_dojo1_dijits/finished/biz-e-corp/package.jso n (relative path: ./node_modules/config-deferredInstrumentation) no extension Field 'browser' doesn't contain a valid alias configuration /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredIns trumentation doesn't exist .ts Field 'browser' doesn't contain a valid alias configuration

/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation.t s doesn't exist .tsx Field 'browser' doesn't contain a valid alias configuration

/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation.t sx doesn't exist .js Field 'browser' doesn't contain a valid alias configuration

/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation.j s doesn't exist as directory /dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredIns trumentation doesn't exist [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation.ts] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation.tsx] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation.js] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/config-deferredInstrumentation] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation. ts] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation. tsx] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation. js] [/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/config-deferredInstrumentation] @ ./node_modules/dojo/Deferred.js 1:0-320:2 @ ./node_modules/dojo/parser.js @ ./node_modules/dojo/ready.js @ ./node_modules/dijit/form/Button.js @ ./src/dijit/form/Button.ts @ ./src/widgets/WorkerForm.ts @ ./src/widgets/App.ts @ ./src/main.ts @ multi ./src/main.css ./src/main.ts,./node_modules/dijit/Fieldset.js Module not found: Error: Can't resolve 'css2' in '/dojo2/1040_dojo1_dijits/finished/biz-e- corp/node_modules/dijit' resolve 'css2' in '/dojo2/1040_dojo1_dijits/finished/biz-e-corp/node_modules/dijit' .....

Thanks for helping... ziegi

ziegi commented 6 years ago

same Problem reported by another Person: https://stackoverflow.com/questions/50447621/how-to-use-dojo-interop-for-dojo1-widgets

agubler commented 4 years ago

I believe this is resolved, please raise a new issue if you are still having issues.