dojo / interop

Provides bindings and interoperability between Dojo packages and other libraries
Other
1 stars 14 forks source link

DijitWrapper Feature #4

Closed kitsonk closed 7 years ago

kitsonk commented 7 years ago

Type: feature

The following has been addressed in the PR:

Description:

This PR provides a way to wrap a Dojo 1 Dijit so that it can be included as part of a Dojo 2 widget rendering process.

Wrapped Dijits can only have other wrapped Dijits as their children. This is because while the widget system still manages the properties on the Dijit instances, after it encounters the first Dijit in a tree it will not render additional DOM.

Resolves #3

codecov[bot] commented 7 years ago

Codecov Report

Merging #4 into master will increase coverage by 4.64%. The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage      90%   94.64%   +4.64%     
==========================================
  Files           1        2       +1     
  Lines          10       56      +46     
  Branches        1       12      +11     
==========================================
+ Hits            9       53      +44     
- Partials        1        3       +2
Impacted Files Coverage Δ
src/dijit/DijitWrapper.ts 95.65% <95.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bce86c5...c75fab6. Read the comment docs.

kitsonk commented 7 years ago

This should be ready to be reviewed now.