agubler commented 4 years ago

Type: feature

The following has been addressed in the PR:

[ ] There is a related issue
[x] All code has been formatted with prettier as per the readme code style guidelines
[ ] Unit or Functional tests are included in the PR

Description:

Adds new supported option for the DrgridWrapper, keepScrollPosition.

Resolves #50

codecov[bot] commented 4 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files           4        4           
  Lines         304      304           
  Branches       81       81           
=======================================
  Hits          269      269           
  Misses         35       35

Impacted Files	Coverage Δ
src/dgrid/DgridWrapper.ts	`88.41% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 216541b...66f3f98. Read the comment docs.

tomdye commented 4 years ago

Should there be an issue for this?

agubler commented 4 years ago

@tomdye added an issue.

dojo / interop

Support keeping scroll position #49

Codecov Report