dojo / meta

:rocket: Dojo - meta information for the project.
Other
226 stars 50 forks source link

Ignore `package-lock.json` #201

Closed kitsonk closed 6 years ago

kitsonk commented 7 years ago

Enhancement

We should ignore package-lock.json at the moment and for the foreseeable future. While the idea is sound in principle of ensure that exactly the same packages are used when a package is shared around from a team, we have run into issues where a localised problem with a package become locked and that localised problem then propagates to others. In particular when there are n versions between the minimum semver and the latest and one of those versions has a bug, that buggy version can easily get locked into the dependency tree and not updated or refreshed. Package maintainers, including ourselves, don't deprecate their buggy point releases of their packages. This generally causes chaos and makes isolating a problem difficult.

The repos:

kitsonk commented 6 years ago

We are now choosing to un-ignore it as versions of npm have addressed most of our concerns.