dojo / meta

:rocket: Dojo - meta information for the project.
Other
226 stars 50 forks source link

Remove @dojo/interfaces #223

Closed matt-gadd closed 6 years ago

matt-gadd commented 6 years ago

Given @dojo/interfaces is now pretty much redundant, we can get rid of it out of our downstream dependencies. To do this for non-cli packages, we simply need to add the remaining stray loader types to @dojo/core (PR here: https://github.com/dojo/core/pull/375). We should then be able to remove the dependency on @dojo/interfaces from all of the following:

After the above, the cli commands currently have a dependency on @dojo/interfaces for the cli typings, if we remove the current circular dependency issue due to bundling @dojo/cli-create-app with @dojo/cli (issue here: https://github.com/dojo/cli/issues/183), we can go ahead and just move these types back into @dojo/cli and make the packages below just rely on @dojo/cli as a dev dep for the typings.

After the above, we can go ahead and remove/deprecate the @dojo/interfaces package and repo.

umaar commented 6 years ago

The pull requests are ready! When "@dojo/cli": "~0.4.2" is published then we can merge them