Pin Node Typings to avoid breakages from - Githubissues

dojo / meta

:rocket: Dojo - meta information for the project.

Other

226 stars 50 forks source link

Pin Node Typings to avoid breakages from #247

Closed maier49 closed 6 years ago

maier49 commented 6 years ago

We need to pin node typings to "@types/node": "~9.6.5" in these repos to prevent/fix breakages from Node 10 types.

[x] @dojo/cli
[x] @dojo/cli-build-app
[x] @dojo/cli-build-webpack
[x] @dojo/cli-create-app
[x] @dojo/cli-create-theme
[x] @dojo/cli-create-widget
[x] @dojo/cli-export-project
[x] @dojo/cli-test-intern
[ ] @dojo/compose (skipped: Deprecated)
[x] @dojo/core
[x] @dojo/has
[x] @dojo/i18n
[x] @dojo/interfaces
[x] @dojo/interop
[x] @dojo/loader
[x] @dojo/routing
[x] @dojo/shim
[ ] @dojo/static-optimize-plugin (skipped: Deprecated)
[x] @dojo/stores
[x] @dojo/streams
[x] @dojo/test-extras
[x] @dojo/webpack-contrib
[x] @dojo/widget-core
[x] @dojo/widgets - https://github.com/dojo/widgets/pull/547

nicknisi commented 6 years ago

I believe @types/node has now been pinned in all versions.