dojo / test-extras

:rocket: Dojo 2 - set of modules to help with testing Dojo.

http://dojo.io

Other

0 stars 14 forks source link

Update harness to use integrated vdom from widget-core #70

Closed kitsonk closed 7 years ago

kitsonk commented 7 years ago

Type: feature

The following has been addressed in the PR:

[ ] There is a related issue
[X] All code matches the style guide
[X] Unit or Functional tests are included in the PR

Description:

This PR updates the harness to be compatible with the integrated vdom from widget-core (PR dojo/widget-core#728.

It also makes a few other changes, some of them breaking:

Uses the Projector instead of accessing the virtual DOM projection directly.
~Uses the Projector in a sandbox mode, therefore widgets are rendered on a document fragment instead of actually in the DOM. This is more consistent with the concepts of harnessing and unit testing.~ Actually that was causing issues on Safari I couldn't fully resolve. Basically Safari 9 doesn't like dispatching events on DOM owned by a document fragment.
Changes the types to make the harness easier to use with no need to explicitly pass generics with widgets. Also .setProperties and .setChildren will now properly type guard. This is a breaking change in that many cases people might have had to specify two generic arguments to have the harness work.

This will need to be updated once the upstream PR is merged and published.

codecov[bot] commented 7 years ago

Codecov Report

Merging #70 into master will decrease coverage by 0.51%. The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   99.08%   98.56%   -0.52%     
==========================================
  Files          10       10              
  Lines         653      626      -27     
  Branches      160      163       +3     
==========================================
- Hits          647      617      -30     
- Misses          0        1       +1     
- Partials        6        8       +2

Impacted Files	Coverage Δ
src/support/assertRender.ts	`98.11% <100%> (+0.74%)`	:arrow_up:
src/support/d.ts	`95.45% <66.66%> (-4.55%)`	:arrow_down:
src/support/sendEvent.ts	`97.43% <93.33%> (-2.57%)`	:arrow_down:
src/harness.ts	`97.87% <95.45%> (+0.03%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80fc66a...2d74245. Read the comment docs.

kitsonk commented 7 years ago

The difference in code coverage is a red herring. Because there was quite a bit of code stripped because of leveraging the projector mixin from widget core, it is causing the code coverage to be 😭

kitsonk commented 7 years ago

The coverage is a bit of a red herring, as it is more related to the changes in widget-core causing some less branch coverage, plus the overall reduction of code because of the removal of the widget.classes logic.

kitsonk commented 7 years ago

I accidentally committed some change to the diagnostics of assert render that I had in another branch which I was going to submit after this PR, but they leaked in, so I merged the rest of them. Overall it just improves the information you get from assert render when something goes wrong, instead of scratching your head, so hopefully we can turn a blind eye.