search

dojo / test-extras

:rocket: Dojo 2 - set of modules to help with testing Dojo.
http://dojo.io
Other
0 stars 14 forks source link

Remove error reporter and intern dep #80

Closed maier49 closed 7 years ago

maier49 commented 7 years ago

Type: feature

The following has been addressed in the PR:

Description: Removes the ClientErrorCollector and makes Intern a devDependency instead of a peerDependency Resolves #79

codecov[bot] commented 7 years ago

Codecov Report

Merging #80 into master will decrease coverage by 0.1%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   98.56%   98.46%   -0.11%     
==========================================
  Files          10        9       -1     
  Lines         626      585      -41     
  Branches      163      158       -5     
==========================================
- Hits          617      576      -41     
  Misses          1        1              
  Partials        8        8
Impacted Files Coverage Δ
src/main.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3af04a...b9dfea7. Read the comment docs.

maier49 commented 7 years ago

The decrease in coverage is just because the remaining files have lower coverage than what's being removed. I tried to add some tests to cover some missing branches but apparently they were already covered in browsers I wasn't testing with.