search

dojo / test-extras

:rocket: Dojo 2 - set of modules to help with testing Dojo.
http://dojo.io
Other
0 stars 14 forks source link

Add better comparison logic for the DNode classes property #81

Closed maier49 closed 7 years ago

maier49 commented 7 years ago

Type: feature

The following has been addressed in the PR:

Description: Uses compareProperty to create a custom diff for classes on the properties of DNodes that ensures only that the actual and expected classes contain equivalent sets of class names. In some cases the order of checks meant that we didn't actually use the custom diff when we should, specifically when the custom diff was on the expected object and the actual object property was an array or object. So this includes a fix for that and tests for it as well. Resolves #78

codecov[bot] commented 7 years ago

Codecov Report

Merging #81 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #81      +/-   ##
=========================================
+ Coverage   98.46%   98.5%   +0.04%     
=========================================
  Files           9       9              
  Lines         585     601      +16     
  Branches      158     164       +6     
=========================================
+ Hits          576     592      +16     
  Misses          1       1              
  Partials        8       8
Impacted Files Coverage Δ
src/support/d.ts 95.45% <ø> (ø) :arrow_up:
src/support/compare.ts 99.5% <100%> (ø) :arrow_up:
src/support/assertRender.ts 98.52% <100%> (+0.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be0b18d...34836b8. Read the comment docs.