Add material snackbar theme

dojo / themes

Dojo Framework Themes

11 stars 19 forks source link

Add material snackbar theme #101

Closed nicknisi closed 4 years ago

nicknisi commented 4 years ago

Type: feature

The following has been addressed in the PR:

[x] There is a related issue
[ ] All code has been formatted with prettier as per the readme code style guidelines
[ ] Unit or Functional tests are included in the PR

Description:

This adds a Material snackbar composed of the theme from @material/snackbar.

Resolves #82

nicknisi commented 4 years ago

@tomdye Do you have any thoughts on how the success and error types should work for the snackbar in the material theme? Here are some ideas:

tomdye commented 4 years ago

Looking at the material guidelines @nicknisi i think that it's just the action buttons that change colour

nicknisi commented 4 years ago

@tomdye ok, if that's the case, the type property won't really have an effect on a material snackbar because the rendering of the actions is completely handled by the actionsRenderer property.

tomdye commented 4 years ago

I'd have imagined that it would apply a class to the wrapper around the action buttons?