Closed mwistrand closed 6 years ago
With these changes, the build becomes a multi-step process:
.d.ts
files for the CSS filesindex.d.ts
Step 2 is a bit of a hack since the webpack build overwrites the index.js
created by tsc
, but of the many approaches I tried this was the only one that allowed for a simple d.ts
at the same level as the compiled index.js
.
@matt-gadd I split out the custom element build, so now:
.m.css
files are copied as-isfonts/
index.css
and index.js
(index.js
does NOT register the theme with window.dojoce
)dojo-{version}.css
and dojo-{version}.js
. This JS file does register the theme with window.dojoce
.@mwistrand that sounds perfect to me 😄
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
When building for release, provide bundled
index.js
andindex.css
files that can be used as-is for themes. This allows individual modules to be used in composition (e.g.,composes: root from '@dojo/themes/dojo/button.m.css
) and also allows the entire theme to be imported as a single, pre-built module. Since@dojo/cli-build-app
(and soon@dojo/cli-build-widget
) will no longer reach up intonode_modules
, applications must now import themes they need into both widget modules andsrc/main.css
.Use
@dojo/scripts
for therelease
command.Resolves #22