search

dojo / themes

Dojo Framework Themes
11 stars 19 forks source link

Add build and local testing documentation #52

Closed msssk closed 4 years ago

msssk commented 5 years ago

Type: feature

The following has been addressed in the PR:

Description:

Add documentation describing how to locally build and test @dojo/themes with @dojo/examples/widget-showcase.

This PR also removes some incorrect (outdated?) documentation from README.md: the listed npm scripts do not exist.

Resolves #51

msssk commented 5 years ago

@ericos What does dojo build -w -s do?

I'm also curious to know what @aciccarello has discovered about the difference between loading index.css and dojo-5.0.0.css. The CSS files are identical, but the associated JS and TS files are different, so we need some clarity on which one we recommend loading.

aciccarello commented 5 years ago

What does dojo build -w -s do?

@msssk That's the dojo cli build command with the --watch and --serve argument shortcuts to rebuild on change and to serve on localhost.

I'm also curious to know what @aciccarello has discovered about the difference between loading index.css and dojo-5.0.0.css. The CSS files are identical, but the associated JS and TS files are different, so we need some clarity on which one we recommend loading.

I think the recommendation is to use the index.css. I was able to get it to work in subsequent builds so I'm not sure what the initial problem was. The other file is unusable because of the included version number. Honestly I didn't look into the js/ts file differences.

agubler commented 4 years ago

Closing as themes will be ported to dojo/widgets as part of dojo 7 and will contain instructions on how to test and build.