search

dojo / typings

Dojo 1 - TypeScript Typings (including Dijit and DojoX)
Other
28 stars 37 forks source link

Build Error TS> 4.4 Cannot find name DocumentEvent #185

Closed davewilton closed 2 years ago

davewilton commented 2 years ago

https://github.com/dojo/typings/issues/184

DocumentEvent is no longer in versions 4.4 onwards of typescript. To me it looks like these should have been Event anyway? The interface for event can be seen at: https://github.com/microsoft/TypeScript/blob/main/lib/lib.dom.d.ts#L5034

The previous interface for document event which it was using can be seen at

https://github.com/microsoft/TypeScript/blob/release-4.3/lib/lib.dom.d.ts#L4908

This PR changes just that issue e.g

onClick(e: DocumentEvent): boolean;

Becomes

onClick(e: Event): boolean;
linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers are authorized under a signed CLA.