search

dojo / util

Dojo 1 - build utilities. Please submit bugs to https://bugs.dojotoolkit.org/
https://dojotoolkit.org/
Other
60 stars 105 forks source link

fix to 17146 #2

Closed rcgill closed 11 years ago

rcgill commented 11 years ago

Write string cache entries before module definition when interning strings as required by some IE loader paths. This fix only affects non-layer resources since layer resources appear to be expressed correctly.

wkeese commented 11 years ago

I didn't get a chance to test this today. I can try tomorrow if no one else has time to do it overnight (Japan time).

The key to testing (and to reproducing the original hang) is to remove all the template files from your build.

wkeese commented 11 years ago

OK, on IE8 I reproduced the failure without the fix, and then confirmed it works with the fix, so this looks good to check in to the master/ and 1.9/ branches.

For the record, the commands I used were:

$ cd util/buildscripts
$ ./build.sh releaseDir=/ws/trunk/release action=release profile=standard
$ cd /ws/trunk/release
$ rm -rf release/dojo/dijit/templates release/dojo/dijit/*/templates
$ cp ie2.html release/dojo

ie2.html is https://bugs.dojotoolkit.org/attachment/ticket/17180/ie2.html

When loading ie2.html on IE8, correct result is that the alert shows up, failure is when the alert doesn't appear.