search

dojo / util

Dojo 1 - build utilities. Please submit bugs to https://bugs.dojotoolkit.org/
https://dojotoolkit.org/
Other
60 stars 105 forks source link

add support for sourcemaps with uglify2 #24

Closed neonstalwart closed 10 years ago

neonstalwart commented 10 years ago

refs https://bugs.dojotoolkit.org/ticket/18341

neonstalwart commented 10 years ago

i'd like to get a few eyes on this to make sure i didn't break something...

cc @csnover @kfranqueiro @liucougar

liucougar commented 10 years ago

looks good to me

thomasbachem commented 10 years ago

That's fantastic! Works well, thank you so much for this quick resolution!

clmath commented 10 years ago

I tested it too and did not find any problems.

csnover commented 10 years ago

I’d like a consensus to exempt this enhancement from our patch rules and apply to the current release branch (1.10.x). Is everyone OK with this? cc @dylans

Kagetsume commented 10 years ago

I am fine with it. On Oct 31, 2014 7:33 PM, "Colin Snover" notifications@github.com wrote:

I’d like a consensus to exempt this enhancement from our patch rules and apply to the current release branch (1.10.x). Is everyone OK with this? cc @dylans https://github.com/dylans

— Reply to this email directly or view it on GitHub https://github.com/dojo/util/pull/24#issuecomment-61344758.

kfranqueiro commented 10 years ago

+1

neonstalwart commented 10 years ago

:+1: I have no objection

uhop commented 10 years ago

+1

liucougar commented 10 years ago

:+1:

dylans commented 10 years ago

:+1:

csnover commented 10 years ago

Landed in 51a1844ee3cedfc669a3ad70e1894e2e5e3e781d and backport to 1.10. Thanks!