search

dojo / util

Dojo 1 - build utilities. Please submit bugs to https://bugs.dojotoolkit.org/
https://dojotoolkit.org/
Other
60 stars 105 forks source link

Fixes 18868 - Hardcoded './util/…' paths in dojo-util break when installed via npm #49

Closed vansimke closed 7 years ago

vansimke commented 7 years ago

add ability to pass 'mapPackage' parameter on the command line to add or override a package definition when invoking dojo (e.g. running the build system.

There are three use cases that have been considered:

  1. Executing Dojo builds
  2. Executing DOH tests using the command line
  3. Executing DOH tests with the browser runner

This PR is intended to address the third use cases. It can't however, completely address it. Any references to the DOH package in the HTML test files will have to be mapped via that page's dojoConfig.

This PR adds the ability to pass a new query parameter "mapPackage" in the test URL to dynamically remap packages. The argument needs to be of the form "name1,value1;name2,value2" where "name" is the value to be passed in the packages "name" field and "location" maps to the packages location, relative to the runner.html page.

jquerybot commented 7 years ago

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

vansimke commented 7 years ago

Closed via https://github.com/dojo/util/commit/55c653333f21a8ea857513901ed4b5560b632ad3