search

dojo / util

Dojo 1 - build utilities. Please submit bugs to https://bugs.dojotoolkit.org/
https://dojotoolkit.org/
Other
60 stars 105 forks source link

add support for compilation levels with Java-driven builds #55

Closed vansimke closed 7 years ago

vansimke commented 7 years ago

This PR was created to add features that were missed in PR 54

sindilevich commented 7 years ago

@vansimke, thanks!

vansimke commented 7 years ago

Closed via https://github.com/dojo/util/commit/21e99ff9ce6b815647f2638274aeb9a350ceff9c

sindilevich commented 7 years ago

@vansimke, when a Java-driven build gets to apply the Google Closure Compiler it throws errors on every file it processes, like the one below:

starting executing global optimizations... starting writing resources... error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: put-selector/put; exception: TypeError: Cannot read property "compilationLevel" from undefined

sindilevich commented 7 years ago

I think bc.optimizeOptions in https://github.com/vansimke/util/blob/69d1bf30b81482e1fe7ffbe24ac278a2d07bd404/build/transforms/optimizer/closure.js#L55 is undefined.