search

dojo / util

Dojo 1 - build utilities. Please submit bugs to https://bugs.dojotoolkit.org/
https://dojotoolkit.org/
Other
60 stars 105 forks source link

optimizeRunner.js catches IllegalArgumentException in shutdownClosureExecutorService #61

Closed pottedmeat closed 7 years ago

pottedmeat commented 7 years ago

https://bugs.dojotoolkit.org/ticket/19025

In the shutdownClosureExecutorService method, the ​Compiler.compilerExecutor value is accessed using ​Field.get by passing in the class object instead of an instance of the class. Accessing an instance field's value requires passing in the instance the value should be read from.

dylans commented 7 years ago

Thanks! Closed via d81fb9e and backported to 1.12 as a93f2ba.

sindilevich commented 7 years ago

@dylans, please reopen the PR and https://bugs.dojotoolkit.org/ticket/19025, since it doesn't fix the issue completely. See https://github.com/dojo/util/commit/d81fb9e35b1a089a0e81c24ce73c4f16d6754842#commitcomment-23156727.