Fix for the issue #79: Closure Compiler Error with ES6 code and Dojo 1.16.0

dojo / util

Dojo 1 - build utilities. Please submit bugs to https://bugs.dojotoolkit.org/

https://dojotoolkit.org/

Other

60 stars 105 forks source link

Closed sindilevich closed 4 years ago

sindilevich commented 4 years ago

The pull request presents a fix for the issue https://github.com/dojo/util/issues/79.

This upgrades the Google Closure Compiler to v20200112, the latest one at the time of the pull request submittal.

This also tweaks the dojo's build system to instruct the Google Closure Compiler compile non-strict-mode JavaScript code.

sindilevich commented 4 years ago

Hello @dylans, any chance to merge the PR?

Thank you in advance!

sindilevich commented 4 years ago

@dylans, thank you a lot for approving the PR! How does that go now, someone should merge the PR into the master? Thank you!

sindilevich commented 4 years ago

Hello @dylans, any chance to merge the PR, after you have already approved it?

Thank you in advance!

dasa commented 4 years ago

There's been three new releases since this PR was created: https://github.com/google/closure-compiler/wiki/Releases

We're also looking forward to this upgrade.

dylans commented 4 years ago

Apologies, don't know why I kept missing this one... will merge it now and include it in the next release.

dylans commented 4 years ago

backported to 1.16 (bf14072), 1.15 (a5c1beb), 1.14 (a2d5ab8), 1.13 (767d903) and 1.12 (0ab48da).

sindilevich commented 4 years ago

Thank you, @dylans!