dojo / util

Dojo 1 - build utilities. Please submit bugs to https://bugs.dojotoolkit.org/
https://dojotoolkit.org/
Other
60 stars 105 forks source link

building dojo project no longer generates output files after update to 1.17 #92

Open rhpijnacker-philips opened 1 year ago

rhpijnacker-philips commented 1 year ago

In our product, we use the dojo build to deploy a number of layers, which are optimized using the closure compiler. After updating to 1.17 we find that, while it does produce the .consoleStripped.js and .uncompressed.js output files, the actually optimized files are no longer generated.

Please note that we already (locally) upgraded the closureCompiler to version 20210601 to allow us to use the newer style JavaScript syntax. Just swapping the 1.17.3 version with this older version fixes the problem of the generated output files.

dasa commented 1 year ago

1.17.3 includes Closure Compiler v20220601. (PR) Any errors in the console or build-report.txt? Are you setting optimizeOptions in your profile?

rhpijnacker-philips commented 1 year ago

There are no errors, and no more warnings than with the older version of the compiler.

Process finished normally
    errors: 0
    warnings: 415
    build time: 52.934 seconds

The only options that we specify are to target a newer JavaScript version:

    optimizeOptions: {
      languageIn: 'ECMASCRIPT_NEXT',
      languageOut: 'ECMASCRIPT_2020'
    },

This was the reason for us to update to 20210601 back in the day.

dasa commented 1 year ago

I don't always trust that summary. I find there can still be errors in the output or build-report.txt file.

rhpijnacker-philips commented 1 year ago

Neither do I, I just copied the summary as "proof".