search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Only clear modules in src #208

Closed agubler closed 5 years ago

agubler commented 5 years ago

Type: bug

The following has been addressed in the PR:

Description:

Built time rendering currently clears all loaded modules when it is run in watch which is problematic and unnecessary, it only needs to unload modules loaded from the project's source. This change filters the modules that are cleared to only modules that live in the project (blocks).

codecov[bot] commented 5 years ago

Codecov Report

Merging #208 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          40       40           
  Lines        1927     1927           
  Branches      526      526           
=======================================
  Hits         1648     1648           
  Misses        279      279
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 97.67% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6783b95...b004ed5. Read the comment docs.