Closed agubler closed 4 years ago
Merging #246 into master will increase coverage by
0.42%
. The diff coverage is98.77%
.
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 84.80% 85.23% +0.42%
==========================================
Files 48 49 +1
Lines 2211 2282 +71
Branches 586 600 +14
==========================================
+ Hits 1875 1945 +70
- Misses 336 337 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/build-time-render/BuildTimeRender.ts | 94.91% <98.50%> (+0.32%) |
:arrow_up: |
src/build-time-render/BuildTimeRenderMiddleware.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8a1d56b...2dd7ed6. Read the comment docs.
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Decouples build time rendering from webpack to be able to use "on demand" for a single path. Includes an express middleware that can be used to generate the static html for a visited path if it has not been generated since the last re-build. Once the html has been generated it will not re-run until the build has invalidated.
Related to https://github.com/dojo/cli-build-app/issues/367