search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Do not inject blocks for static sites and never delete the root index.html #248

Closed agubler closed 4 years ago

agubler commented 4 years ago

Type: bug

The following has been addressed in the PR:

Description:

No javascript should be injected for static pages. The root index.html should never be removed as it will always be "reset" by the webpack build.

codecov[bot] commented 4 years ago

Codecov Report

Merging #248 into master will decrease coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   84.43%   84.35%   -0.09%     
==========================================
  Files          46       46              
  Lines        2101     2103       +2     
  Branches      564      566       +2     
==========================================
  Hits         1774     1774              
- Misses        327      329       +2
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 94.54% <100%> (-0.55%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ac6ac0...cdfc740. Read the comment docs.