rorticus commented 4 years ago

… are not used in the render. (#254)

Type: feature

The following has been addressed in the PR:

[x] There is a related issue
[x] All code has been formatted with prettier as per the readme code style guidelines
[x] Unit or Functional tests are included in the PR

Description:

Updating the custom element transformer to look at the type of the render callback, rather than the type of the properties being used by render. This should let us discover properties applied by the middleware but never pulled into a widget.

Resolves #254

codecov[bot] commented 4 years ago

Codecov Report

Merging #255 into master will decrease coverage by 0.08%. The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   84.63%   84.55%   -0.09%     
==========================================
  Files          48       48              
  Lines        2167     2162       -5     
  Branches      577      571       -6     
==========================================
- Hits         1834     1828       -6     
- Misses        333      334       +1

Impacted Files	Coverage Δ
src/element-transformer/ElementTransformer.ts	`96.96% <94.11%> (-0.85%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 316727f...3bfebcf. Read the comment docs.

rorticus commented 4 years ago

GH isn't letting me reply to your feedback @maier49 so I'll do this the old fashioned way. ts.ObjectFlags.Reference should never be undefined because its an enum value, and yes! I can, and did, collapse those two if conditionals, nice catch!

dojo / webpack-contrib

Updating element transformer to pull in properties even if properties… #255

Codecov Report